Port exception found in System.Composition.Hosting source comments to… #2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mairaw @rpetrusha Please take a look whenever you get a chance. Adding area owners @maryamariyan, @ViktorHofer in case they have any additional comments or suggestions about the description of this missing exception. |
rpetrusha
suggested changes
Apr 16, 2019
There was a problem hiding this comment.
Thanks for adding this exception, @carlossanlop. I've suggested a change so that it conform to our general pattern for exception conditions.
Co-Authored-By: carlossanlop <[email protected]>
rpetrusha
approved these changes
Apr 25, 2019
|
Thanks, @carlossanlop. I'll merge your PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Docs
Summary
Automatically ported an exception found in the triple slash souce code comments in System.Composition.Hosting that was not found in dotnet-api-docs.
The exception summary was originally empty, so I found the root cause that would throw it in this function:
https://github.com/dotnet/corefx/blob/a6f76f4f620cbe74821c6445af3f13e048361658/src/System.Composition.Hosting/src/System/Composition/Hosting/Core/ExportDescriptorRegistry.cs#L51
Fixes #Issue_Number (if available)